[Bug 603346] Review Request: php-voms-admin - Web based interface to control VOMS parameters written in PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603346

--- Comment #5 from Lev Shamardin <shamardin@xxxxxxxxx> 2011-06-06 16:52:24 EDT ---
Hi Andrii,

First of all, thanks for a prompt reply.

I have tested your spec with a checkout of pva-0.5.1 tag, the errors I
mentioned in the comment above are still relevant for this version. I suppose,
something is broken with php includes, since I can see the sources of the
regex.php and langdetect.php in the  .../pva/ page source. I'm not a php
expert, but I suspect that ini_set directives should be avoided in the
production code, and should be moved out to the configuration (probably to
/etc/httpd/conf.d/pva.conf).

Second, there is one critical thing missing in your version of the spec-file,
namely instructions how to get the sources from the upstream version control
system (see http://fedoraproject.org/wiki/Packaging/SourceURL).

And the last question, do you have a FAS account, and, if you do, are you in
the 'packager' group? If not, either Mattias should maintain and submit the
spec for this package, or you should follow the sponsorship procedure described
in http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]