Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: thunar-archive-plugin - Archive plugin for the Thunar file manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215241 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2007-01-02 17:30 EST ------- (In reply to comment #14) > * rpmlint is silent > X license seems to be LGPL, license included but is GPL in specfile Sorry, my fault. COPYING and headers are LGPL, so the specfile is wrong. > It is not obvious that the gtk cache update is needed, but I guess it > is needed for the icons in the right-click thunar menu? I did not really test if it's necessary, I just strictly followed the guidelines. The guidelines tell you to run gtk-update-icon-cache, "If an application installs icons into one of the subdirectories in %{_datadir}/icons". > The scriptlet snippet isn't the same than in the guidelines but the > one proposed here should be right, too. Oops, I copied it over from another specfile, obviously the Scriptlet Snipplets in the Wiki have changed in the meantime. The page I used is http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=recall&rev=1#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda > The only real issue pending is the License issue. This is APPROVED if you > fix it, no need to repost a srpm if it is the only difference. OK, thanks a lot for reviewing this so carefully. I will fix the license issue after import into CVS. I will also update the icon cache scriptlet (if it is really needed). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review