Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221188 josef@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: pdns- |Review Request: pdns- |recursor - Modern, advanced |recursor - Modern, advanced |and high performance |and high performance |recursing/non authoritative |recursing/non authoritative |nameserver |nameserver ------- Additional Comments From josef@xxxxxxxxxxxxxx 2007-01-02 16:56 EST ------- Here is my review, everything looks good, it built and such. I haven't yet been sponsored and stuff, I'm doing reviews in order to get sponsored. Must: -rpmlint ran without errors [josef@dhcp59-136 ~]$ rpmlint pdns-recursor-3.1.4-1.src.rpm [josef@dhcp59-136 ~]$ -package conforms to package naming guidlines -spec file name matches basename -the package is licensed with an open source compatible license -package includes license in %doc -spec file is written in american english -spec file is legible -sources match upstream (sha1sum) d1fa344ec5f2feb12397361f92b011a0cb726d48 pdns-recursor-3.1.4.tar.bz2 -package successfully built on my test box (x86_64) -no need for exclude arch -BR are present and make sense -no libraries, no need to run ldconfig -not relocatable -package owns everything it creates -package does not duplicate files it owns -file attributes are set appropriatly -%clean section present and removes buildroot -consistently uses macros -contains code -no large documentation -files in %doc does not affect runtime of application -does not contain a pkgconfig file -does not contain any libraries -does not have a devel package -does not contain any .la files -package does not have a gui -package does not own files/directories owned by other packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review