[Bug 221175] Review Request: libisofs - A library to create ISO 9660 disk images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libisofs - A library to create ISO 9660 disk images


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221175





------- Additional Comments From jkeating@xxxxxxxxxx  2007-01-02 16:22 EST -------
(In reply to comment #1)
> - All build dependencies are spurious
Ah, probably carryover from when the package was built in libburn.

> - "-n libisofs-devel" could be replaced by just "devel" in devel's %package and
>   %description, and libisofs by %{name} in -devel main pkg dependency

Whoops, more carry over from previous package.

> - Summary: s/A library/Library/

Fixed.

> - Unowned dir /usr/include/libisofs

Hrm, I assumed that it would pick up ownership of that since it was creating the
dir, my bad.

> - Add CONTRIBUTORS to %doc

Hurray for new files.

> - Quite a few executable permissions in -debuginfo source files

This is a complaint with upstream that I've asked them to fix.  Is this really a
problem that I should chmod the source?

> - Dubious Cflags in *.pc, should be -I${includedir}/libisofs?

Upstream issue, I'll ask them to fix it for the next release.

> - Is the libburn dependency really needed in the main package?

I was told yes, but I'll clarify.

> - Bad grammar in %description: "libisofs the library to ...", dunno if the last
>   sentence of it is needed, it's subject to bitrot

Yeah, this was their upstream content.


http://people.redhat.com/jkeating/extras/libisofs-0.2.3-2.src.rpm
Spec url is the same.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]