Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710672 Mario BlÃttermann <mariobl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #3 from Mario BlÃttermann <mariobl@xxxxxxxxxx> 2011-06-04 16:48:46 EDT --- (In reply to comment #2) > Thanks for the hint. However I consider this a minor problem and not worth > rolling a new package at this point. I would rather prefer somebody first does > a complete review and then I fix all problems found. I agree with you. It was just a cosmetic issue which I get from rpmlint. Complete rpmlint output: $ rpmlint -v * pnmixer.src: I: checking pnmixer.src: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular pnmixer.src: W: spelling-error %description -l en_US unmute -> mute pnmixer.src: E: description-line-too-long C * Continuous volume adjustment when dragging the slider (not just when you let go) pnmixer.src: I: checking-url https://github.com/nicklan/pnmixer/wiki (timeout 10 seconds) pnmixer.src: I: checking-url https://github.com/downloads/nicklan/pnmixer/pnmixer-0.2.tar.gz (timeout 10 seconds) pnmixer.x86_64: I: checking pnmixer.x86_64: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular pnmixer.x86_64: W: spelling-error %description -l en_US unmute -> mute pnmixer.x86_64: E: description-line-too-long C * Continuous volume adjustment when dragging the slider (not just when you let go) pnmixer.x86_64: I: checking-url https://github.com/nicklan/pnmixer/wiki (timeout 10 seconds) pnmixer.x86_64: W: obsolete-not-provided obmixer pnmixer.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/pnmixer.desktop pnmixer.x86_64: W: no-manual-page-for-binary pnmixer pnmixer-debuginfo.x86_64: I: checking pnmixer-debuginfo.x86_64: I: checking-url https://github.com/nicklan/pnmixer/wiki (timeout 10 seconds) pnmixer.spec: I: checking-url https://github.com/downloads/nicklan/pnmixer/pnmixer-0.2.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 2 errors, 7 warnings. The warnings could be ignored, also the description line. The obsolete-not-provided is because pnmixer obsoletes older versions of obmixer and don't provide obmixer itself. If pnmixer is *not* the official successor of obmixer, this warning could be ignored too. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv3+ [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 20e62e73d970cf63b2bac52077453f02 pnmixer-0.2.tar.gz 20e62e73d970cf63b2bac52077453f02 pnmixer-0.2.tar.gz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. Although there is a l10n infrastructure, no translations available yet. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. The -p switch is applied to "install" [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. No manpage available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review