[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708765

--- Comment #48 from Mario Sanchez Prada <msanchez@xxxxxxxxxx> 2011-06-04 02:39:57 EDT ---
Created attachment 502955
  --> https://bugzilla.redhat.com/attachment.cgi?id=502955
Additional patches that might be interesting to apply

You (fedora packagers) might also find interesting applying two additional
patches that also are being applied specifically in the debian package:

  0001-Fix-segfault-when-no-valid-uris-are-passed-via-comma.patch
  0002-Updated-manpage-to-use-uri-instead-of-path.patch

Those are not strictly needed, but good to have.

The first one is about fixing a segfault in the _very unlikely_ case the user
runs frogr from command line with wrong arguments (currently frogr only
supports URIs to files as arguments, so even frogr --help will segfault. Yes,
sad but true). The command line arguments are not intented to be used directly
by the user but we need that frogr supports that in order to properly act as a
handler for picture mimetypes, so you can "right click" on a picture in
nautilus/eog/... and "Open with frogr...".

The second one is about updating the manpage, which should say "uri" instead of
"path" after the following patch was applied for frogr 0.5:

http://git.gnome.org/browse/frogr/commit/?id=42196942bc467e7e97e69e5b06cddea3e8f2a6f7

About debian packages already bundling these two patches, here you have the
mail were frogr 0.5-1 was accepted, where you can see them:

http://lists.debian.org/debian-devel-changes/2011/05/msg02377.html

Now it's for real... have a nice weekend!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]