Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qwtplot3d - Qt/OpenGL-based C++ library providing a bunch of 3D-widgets for programmers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221163 ------- Additional Comments From mr.ecik@xxxxxxxxx 2007-01-02 13:49 EST ------- REVIEW: * rpmlint is not quiet: E: qwtplot3d-devel only-non-binary-in-usr-lib but we can ignore that until a file in /usr/lib is symlink to a binary one * sources match upstream (7ef960d7874f78162d6c9d241de2843e) * BRs listed well (mock builds fine) * license is in fact zlib/libpng (checked) !* -devel subpackage present, but needs to be improved * name of package is good as well as spec file name * proper %post and %postun sections * package isn't designed to be relocatable * there's no duplicates in %files section * package owns files and directories well * proper %clean section * %defattr macros are present * macros are used good THING TO DO: - some header files include files like a qstringlist.h which are owned by qt-devel package. Thus you have to add qt-devel dependency to -devel subpackage. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review