Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709125 Volker FrÃhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #2 from Volker FrÃhlich <volker27@xxxxxx> 2011-06-03 19:24:07 EDT --- Please remove the Requires. RPM is smart enough to figure out these two. Please put each BuildRequires on a separate line, as it is more legible. If you don't plan to maintain your package in EPEL 5 or older, you can remove the buildroot definition and the buildroot cleaning. You can drop %defattr as well. The files section could be a bit more specific -- Especially for the bindir. Feel free to add the TODO file to %doc, if you find it useful. make and rm macros are no longer used -- just use plain make and rm. Despite that, please use %cmake instead of cmake. Please adapt your Cmake files to use the system's sqlite and also add it to the BRs. Therefore, also delete the tarball's libs directory in the prep section. The package description should end in a full stop. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review