[Bug 682544] Review request: gargoyle - multi-format interactive fiction interpreter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682544

--- Comment #8 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-06-03 16:59:22 EDT ---
I note that this program appears to bundle multiple separate upstream projects,
in contravention of the Fedora packaging guidelines.

Have a look at the following:
http://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_of_multiple_projects
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries

Simply, separate upstream projects should be packaged separately and this
package can depend on them.  (It must delete the source code, even for the free
ones, in %prep.  This is in addition to deleting the non-distributable ones
from the tarball.)  If it's properly written (finds the available interpreters
at runtime), someone could even separately package up the non-free ones and
distribute them outside of the project.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]