Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710452 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-06-03 14:11:02 EDT --- Yet another wrapper around gzip..? A few notes, I hope Nils won't mind :) - Drop the empty directives %pre %post %preun %postun - Drop the explicit Requires: on zlib, it is picked up automatically by RPM. (It's also forbidden in the Fedora Packaging guidelines at http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires ) - In case the man page compression format changes, it's better to use %{_mandir}/man1/%{name}.1.* instead of %{_mandir}/man1/%{name}.1.gz Otherwise looks good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review