Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710194 --- Comment #4 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-06-02 16:20:14 EDT --- (In reply to comment #3) > (In reply to comment #2) > > Unless you plan on using the same spec file > > with EPEL, some elements of the spec file can be removed: the python_sitelib > > definition at the top, BuildRoot, "rm -rf %{buildroot}" at the top of %install, > > the %clean script, and %defattr in %files. > > I was aware of everything except the "rm -rf..." in install and the %defattr. > Have the packaging guidelines been updated to reflect all of this? Never mind... I found them. It could be a little more explicit. I don't know why but I feel better with %defattr there but I'll remove the rest. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review