Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalev@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kalev@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Kalev Lember <kalev@xxxxxxxxxxxx> 2011-06-02 14:12:46 EDT --- Taking for review. I'm looking at the installed public headers and jmorecfg.h still has: typedef int boolean; This is going to cause trouble because Windows headers (in particular rpcndr.h) define boolean as 'unsigned char'. libjpeg-turbo has two different build systems. In addition to the autotools-based one you've used, there's also a CMake based build system. It would appear that there's at least one important difference for MinGW builds: the cmake build system uses win/jconfig.h.in, which in turn defines: /* Define "boolean" as unsigned char, not int, per Windows custom */ #ifndef __RPCNDR_H__ /* don't conflict if rpcndr.h already read */ typedef unsigned char boolean; #endif #define HAVE_BOOLEAN /* prevent jmorecfg.h from redefining it */ So in the light of this, I can suggest two options: 1) Fix up the autotools build system to also typedef boolean as 'unsigned char' 2) Switch to CMake build system -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review