[Bug 709928] Review Request: publican-openshift - Common documentation files for the OpenShift brand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709928

Ruediger Landmann <r.landmann@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.landmann@xxxxxxxxxx

--- Comment #2 from Ruediger Landmann <r.landmann@xxxxxxxxxx> 2011-06-01 23:24:34 EDT ---
(In reply to comment #1)

> mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 5)

Most of the time, you've used a tab to separate field labels from their
contents, but used spaces in these two lines:

ExclusiveArch:   i686 x86_64
BuildArch:   noarch

Please replace the spaces in these two lines with tabs. You can have one or the
other, but you can't mix up the two styles in the one spec file.

> 0: test: ==: unary operator expected

This is occurring because {?dist} is undefined in whatever environment you're
running rpmlint in; this won't be an error in an actual build, since {?dist}
will always be defined. Safe to ignore.

When you've fixed the mixed-spaces-and tabs issue, please:
* bump the Release number in the spec file (and make a note in the %changelog)
* rebuild the package
* run rpmlint over the spec, SRPM, and RPM and post the fresh results here
* if no new errors have appeared, you should also:
** upload the new spec and SRPM somewhere on the web and link to them here
** do a fresh scratchbuild in Koji and link to it here.

Cheers
Rudi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]