[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708765

--- Comment #21 from Mario BlÃttermann <mariobl@xxxxxxxxxx> 2011-06-01 17:44:18 EDT ---
(In reply to comment #19)
> - You should drop the flags "-Wall -g0 -O2" from CFLAGS in file configure.ac 
>   as they overwrite Fedora's %optflags and lead to debuginfo packages without 
>   sources.

Just tested it with the following patch:

--- configure.ac 2011-06-01 23:28:51.084852332 +0200
+++ configure.ac 2011-06-01 23:30:08.294665301 +0200
@@ -140,7 +140,7 @@
    AC_DEFINE([DEBUG_ENABLED], [1], [Debug enabled])
    CFLAGS="$CFLAGS -DG_ENABLE_DEBUG -DG_ERRORCHECK_MUTEXES -Wall -Werror -g3
-O0"
 else
-   CFLAGS="$CFLAGS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS
-DG_DISABLE_CAST_CHECKS -Wall -g0 -O2"
+   CFLAGS="$CFLAGS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS
-DG_DISABLE_CAST_CHECKS "
 fi

 # Substitute


But compiling fails with the following error:

+ make -j3
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh
/home/mariobl/rpmbuild/BUILD/frogr-0.5/missing --run aclocal-1.11 -I m4
aclocal-1.11: couldn't open directory `m4': No such file or directory
make: *** [aclocal.m4] Error 1

Is that due to my change?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]