[Bug 703698] Review Request: gx_head - a mono tube amplifier (guitarix branch)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=703698

Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #1 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2011-05-31 22:09:20 EDT ---
Hi Brendan, here is my review:

! %description may need some implevement, such as 
   witch -> which
   could be load -> could be loaded
   could connected -> could be connected
   etc

? There are a bunch of files that get installed in /usr/share/gx_head/sounds/
and they have 664 permissions instead of the standard 644. Search for the
string "664" in the wscript file. I don't think that this is a blocker but do
you know if there is a reason for this? 

! In addition to the above rpmlints, which can be ignored, I got the following:
   gx_head.x86_64: W: no-manual-page-for-binary gx_head
      ignore this one
   gx_head.x86_64: W: file-not-in-%lang
/usr/share/locale/es/LC_MESSAGES/gx_head.mo
   gx_head.x86_64: W: file-not-in-%lang
/usr/share/locale/fr/LC_MESSAGES/gx_head.mo
   gx_head.x86_64: W: file-not-in-%lang
/usr/share/locale/it/LC_MESSAGES/gx_head.mo
      This is a blocker. We install locales in a special way. See below.
   some 100+ "incorrect-fsf-address" warnings
      There was a discussion in the devel list a few days ago. Folks said it
would be good to notify the upstream about this issue.

* The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. Please see
   http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]