[Bug 707819] Review Request: DSDP - Software for semidefinite programming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707819

--- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-05-31 17:36:09 EDT ---
I built it under mock for x86_64 since I'm still running F14. Here's the
rpmlint output:

$ rpmlint DSDP.spec DSDP-5.8-1.fc15.src.rpm DSDP-5.8-1.fc15.*.rpm
DSDP.spec: W: invalid-url Source1: DSDP-man.tar.xz
DSDP.src: W: spelling-error Summary(en_US) semidefinite -> semi definite,
semi-definite, definiteness
DSDP.src: W: spelling-error %description -l en_US semidefinite -> semi
definite, semi-definite, definiteness
DSDP.src: W: invalid-url Source1: DSDP-man.tar.xz
DSDP.src: W: spelling-error Summary(en_US) semidefinite -> semi definite,
semi-definite, definiteness
DSDP.src: W: spelling-error %description -l en_US semidefinite -> semi
definite, semi-definite, definiteness
DSDP.src: W: invalid-url Source1: DSDP-man.tar.xz
DSDP.x86_64: W: spelling-error Summary(en_US) semidefinite -> semi definite,
semi-definite, definiteness
DSDP.x86_64: W: spelling-error %description -l en_US semidefinite -> semi
definite, semi-definite, definiteness
DSDP.x86_64: W: shared-lib-calls-exit /usr/lib64/libdsdp.so.5.8
exit@xxxxxxxxxxx
DSDP.x86_64: E: non-standard-executable-perm /usr/lib64/libdsdp.so.5.8 0775L
3 packages and 1 specfiles checked; 1 errors, 10 warnings.

I'm thinking we should fix the error. Maybe change the "cp -p" to "install -p
-m 0755..."

I made the change and it worked. I also did this for the DSDP-exmples after I
realized I forgot to run rpmlint on those packages as well.


I'm not sure what we should do about the last warning...
---
$ rpmlint -I shared-lib-calls-exit
shared-lib-calls-exit:
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
---
Is this a problem?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]