Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690569 Petr Sabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Petr Sabata <psabata@xxxxxxxxxx> 2011-05-31 04:14:51 EDT --- --- a/perl-Task-Perl-Critic.spec +++ b/perl-Task-Perl-Critic.spec @@ -6,7 +6,6 @@ License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/Task-Perl-Critic/ Source0: http://www.cpan.org/authors/id/E/EL/ELLIOTJS/Task-Perl-Critic-%{version}.tar.gz -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch BuildRequires: perl(Module::Build) # Other requires from META.yml are not needed at build and check time. There @@ -40,7 +39,7 @@ This module does nothing but act as a placeholder. See Task. %setup -q -n Task-Perl-Critic-%{version} %build -%{__perl} Build.PL installdirs=core +%{__perl} Build.PL installdirs=vendor ./Build %install @@ -52,9 +51,8 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; ./Build test %files -%defattr(-,root,root,-) %doc Changes LICENSE README -%{perl_privlib}/* +%{perl_vendorlib}/* %{_mandir}/man3/* %changelog @@ -63,5 +61,5 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; - Do not BuildRequire run-time dependencies, they are not used at build and check time indeed. - Remove BuildRoot stuff -- Install into perl core directory +- Remove explicit defattr -- Approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review