Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fakechroot - Gives a fake chroot environment https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220889 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-01-01 12:56 EST ------- Well, A. From http://fedoraproject.org/wiki/Packaging/Guidelines = Licensing -- is not LGPL and this is correct * Use rpmlint ------------------------------------------------- W: fakechroot doc-file-dependency /usr/share/doc/fakechroot-2.5/ldd.fake /usr/bin/perl ------------------------------------------------- Well.. I understood first when I read the following. ------------------------------------------------- doc-file-dependency : An included file marked as %doc creates a possible additional dependency in the package. Usually, this is not wanted and may be caused by eg. example scripts with executable bits set included in the package's documentation. ------------------------------------------------- For this package, ------------------------------------------------- [tasaka1@localhost ~]$ rpm -q --requires fakechroot /bin/sh /usr/bin/perl <- THIS libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdl.so.2 libdl.so.2(GLIBC_2.0) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) -------------------------------------------------- and /usr/bin/perl is actually not necessary. When I all changed the permission of %doc files to 0644, -------------------------------------------------- [tasaka1@localhost i386]$ rpm -qp --requires fakechroot-2.5-11.1.i386.rpm /bin/sh libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdl.so.2 libdl.so.2(GLIBC_2.0) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) ---------------------------------------------------- and the dependency for /usr/bin/perl disappears. Change the permission of %doc files to 0644. (However, I think this is somewhat bug of rpmbuild?) B. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines = This is okay, except for written in A. Please fix the issues in A. Other things are okay. -------------------------------------------------------- This package (fakechroot) is APPROVED by me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review