[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708670

Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2011-05-30 09:56:23 EDT ---
tarball is now OK (md5sum dc1a98b5cf60e90fb79a33fc003c2af9)

javadoc subpackage should have license file included as well. 

maven plugin subpackage should have separate Group tag (even if it's the same
as in this case). 

You now also have this in file section:
%{_mavendepmapfragdir}/

i.e. you own whole subdir, whereas you should only own file inside it i.e.
%{_mavendepmapfragdir}/%{name} (or *)

Otherwise the package looks OK now, so just fix those 3 small issues and you're
good to go. In good faith: APPROVED :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]