Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705760 Ondrej Vasik <ovasik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #1 from Ondrej Vasik <ovasik@xxxxxxxxxx> 2011-05-30 08:33:47 EDT --- Checked srpm: $ sha256sum retrace-server-1.0-1.fc15.src.rpm a9e53fe5651227206cd101c77dff268ee94102d3ac767d9612954df58dbe4c82 retrace-server-1.0-1.fc15.src.rpm YES source files match upstream: $ sha256sum retrace-server-1.0.tar.gz retrace-server-1.0.tar.gz.1 eecdf3dc7995b5d103d8b10845f3ef7e98f6a49aa54e474037ad8dee13832dea retrace-server-1.0.tar.gz eecdf3dc7995b5d103d8b10845f3ef7e98f6a49aa54e474037ad8dee13832dea retrace-server-1.0.tar.gz.1 YES package meets naming and versioning guidelines. YES specfile is properly named, is cleanly written and uses macros consistently. YES dist tag is present. INFO clean section and buildroot not present - but that's ok now YES license field matches the actual license. YES license is open source-compatible YES License text included in package. YES latest version is being packaged. YES BuildRequires are proper. YES compiler flags are appropriate. YES package builds in mock (Rawhide/x86_64). YES debuginfo package looks complete. NO rpmlint is silent. Output already posted in description, confirmed. Manual pages would be nice to have, but at the moment in the "release early, release often" stage ... I hope this will improve in future. At lease info documentation is present. YES final provides and requires look sane. N/A %check is present and all tests pass. YES no shared libraries are added to the regular linker search paths. YES owns the directories it creates. YES doesn't own any directories it shouldn't. YES no duplicates in %files. YES scriptlets must be sane. YES code, not content. N/A large documentation files must go in a -doc subpackage. YES %docs are not necessary for the proper functioning of the package. YES no headers. YES no pkgconfig files. YES no libtool .la droppings. YES not a GUI app. Few comments: %{?el6:Requires: python-argparse} ... is this really only for el6? If so, it probably could be dropped in Fedora, otherwise it should probably be extended to rhel conditional. You have requested retrace account in https://bugzilla.redhat.com/show_bug.cgi?id=706012 ... it is no longer required? None of these comments is blocking the approval -> APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review