Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #6 from Volker FrÃhlich <volker27@xxxxxx> 2011-05-29 16:16:16 EDT --- The buildroot definition is also unnecessary then. Please take a look at the result of licensecheck: ... shinken/contactdowntime.py: AGPL (v3 or later) shinken/bin.py: AGPL (v3 or later) shinken/db_oracle.py: AGPL (v3 or later) shinken/log.py: AGPL (v3 or later) ... All the files say AGPLv3+ -- not AGPLv3. Why don't you include FROM_NAGIOS_TO_SHINKEN? Is it not relevant to users of Shinken? With "changelog" I meant what's inside the spec file. Just by looking at the changelog "you fixed something and you replaced some macro". Just put it there like you put it above. What about the unit tests? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review