Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706705 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> 2011-05-29 09:06:10 EDT --- Taking this one, I'll also sponsor Felipe once this review is done Full review done: Good: - rpmlint checks return: rpmlint rpmbuild/SRPMS/libmtag-python-0.3.1-1.fc15.src.rpm rpmbuild/RPMS/x86_64/libmtag-python-* libmtag-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libmtag.so libmtag.so()(64bit) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. These can all be ignored - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: =========== -package does not meet naming guidelines, python modules should be called python-name rather then name-python, see: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 So the package (and the specfile) should be named python-libmtag, I realize this contradicts what upstream does, but Fedora names all python modules this way for consistency -There is no clear license info available in the upstream source tarbal, please ask upstream (I think that may mean asking yourself :) to add a LICENSE file and proper copyright headers to the source files. -Please include NEWS in the %doc files -It is ok to include the egginfo file in the Fedora package, see: http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns But if you consider it not useful to have it is ok to leave it out too -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review