Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | Flag| |fedora-review+ --- Comment #14 from Hans de Goede <hdegoede@xxxxxxxxxx> 2011-05-29 08:55:35 EDT --- Full review done (again): Good: - rpmlint checks return: rpmlint rpmbuild/SRPMS/libmtag-0.3.6-1.fc15.src.rpm rpmbuild/RPMS/x86_64/libmtag-* libmtag.src: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end libmtag.x86_64: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end libmtag-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. These can all be ignored - package meets naming guidelines - package meets packaging guidelines - license (GPLv2) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Approved! I'll sponsor you once python-libmtag is also approved, removing the needsponsor blocker -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review