Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700350 --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2011-05-29 00:55:52 EDT --- There are a couple of issues with this one. Please don't patch the LICENSE file to fix the address. It's good to see that you're running rpmlint on your packages, but the incorrect-fsf-address "error" is not a review blocker and should be handled simply by asking upstream to update the address. You should remove the perl(Test::More) runtime dependency. And, as always, I would like to see the test suite actually test something rather than bail out because memcached isn't running. You could buildrequire memcached and perl(Cache::Memcached), then start memcached in %check and ensure that it is killed properly after running the tests. Something like: %check memcached -l 127.0.0.1 & make test || rc=$? kill %1 exit $rc (And while testing this, I discovered an error in perl-CGI-Session packaging - it needs to explicitly require perl(CGI). Fixed in rawhide, and I've submitted updates for f14 and f15). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review