[Bug 702103] Review Request: python-osmgpsmap - Python bindings for osm-gps-map GTK+ widget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702103

Volker FrÃhlich <volker27@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27@xxxxxx

Bug 702103 depends on bug 701982, which changed state.

Bug 701982 Summary: Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles
https://bugzilla.redhat.com/show_bug.cgi?id=701982

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #5 from Volker FrÃhlich <volker27@xxxxxx> 2011-05-28 17:21:30 EDT ---
http://fedoraproject.org/wiki/Common_Rpmlint_issues#private-shared-object-provides

%{?filter_setup:
%filter_provides_in %{python_sitearch}/.*\.so$ 
%filter_setup
}

will likely do the job.

You missed the COPYING file. Therefore you can drop the README, as it only
contains information on installing.

I'd suggest using %{python_sitearch}/osmgpsmap.so instead of the wildcard.

Please be a bit more detailed in the changelog, as the reader can't easily
figure out which BRs you added, for instance.

As you have a clean section, a buildroot definition and clean the buildroot,
you're seemingly set for EPEL 5. If so you must also add something like:

%if ! (0%{?rhel} > 5)
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

Otherwise feel free to drop all the aforementioned. You can also drop the
%defattr: https://fedorahosted.org/fpc/ticket/77

You can use %setup instead of %setup0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]