Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: prelude-lml - Prelude log analyzer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209222 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-01-01 03:27 EST ------- Well, for prelude-lml: * -devel package issues - First of all, is this package of any sense? I don't know how only installing one header file without providing any .so symlink libraries can be used for any other applications. For example, /usr/include/prelude-lml/prelude-lml.h contains ------------------------------------------------------------ const char *lml_log_entry_get_message(const lml_log_entry_t *log_entry); ------------------------------------------------------------ However, to what library should I actually link to use this function *lml_log_entry_get_message ? The other things are: - prelude-lml.h includes: ------------------------------------------------------------- #include <libprelude/prelude.h> #include <libprelude/prelude-log.h> ------------------------------------------------------------- This means that -devel package should need "Requires: libprelude-devel" - The description of Requires is wrong. * BuildRequires: -------------------------------------------------------------- BuildRequires: libprelude, libprelude-devel, pcre-devel -------------------------------------------------------------- - "libprelude" is not necessary - mockbuild log says: -------------------------------------------------------------- <snip> checking for pcre-config... /usr/bin/pcre-config checking for pcre_get_named_substring in -lpcre... yes checking fam.h usability... no checking fam.h presence... no checking for fam.h... no checking for FAMOpen in -lfam... no checking whether FILENAME_MAX is declared... yes checking for an ANSI C-conforming const... yes <snip> *** Dumping configuration *** - Enable FAM support : no - Enable unsupported rulesets: : yes + make <snip> -------------------------------------------------------------- Why is FAM support disabled? NOTE: fam.h is included in gamin-devel. * For debuginfo issue: - Mockbuild log says: --------------------------------------------------------------- + rm -f /var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild//usr/lib/prelude-lml/debug.la + rm -f /var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild//usr/lib/prelude-lml/pcre.la + /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/prelude-lml-0.9.8.1 extracting debug info from /var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild/usr/bin/prelude-lml extracting debug info from /var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild/usr/lib/prelude-lml/pcre.so extracting debug info from /var/tmp/prelude-lml-0.9.8.1-1.fc7-root-mockbuild/usr/lib/prelude-lml/debug.so cpio: prelude-lml-0.9.8.1/src/.libs/prelude-lmlS.c: No such file or directory <- THIS LINE 377 blocks + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump --------------------------------------------------------------- The description of "THIS LINE" means that a needed file for debugging this package is missing and this should be fixed. Again mockbuild log says --------------------------------------------------------------- creating .libs/prelude-lmlS.c (cd .libs && gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -c -fno-builtin "prelude-lmlS.c") rm -f .libs/prelude-lmlS.c .libs/prelude-lml.nm .libs/prelude-lml.nmS .libs/prelude-lml.nmT --------------------------------------------------------------- "rm -f .libs/prelude-lmlS.c" is wrong and this should not be done. * Documentation - Some %doc files are encoded with non-UTF-8 encodings. Please change to UTF-8. --------------------------------------------------------------- /usr/share/doc/prelude-lml-0.9.8.1/ChangeLog: ISO-8859 English text /usr/share/doc/prelude-lml-0.9.8.1/NEWS: ISO-8859 English text --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review