Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698051 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> 2011-05-26 15:56:04 EDT --- I have some preliminary comments. First, where did you get the source files? I can't seem to locate them. There are files for download from sourceforge, but none of them appear to match these files. If you generated them from subversion, please see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning. Second, the URL in the spec file leads to a page that declares itself obsolete, and points to http://spimsimulator.sourceforge.net/. Should that be the URL given in the spec file? Third, the patch needs a comment; see https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment. Fourth, some elements of the spec file are no longer needed, namely BuildRoot, %clean, and %defattr in %files. Fifth, change "/usr/bin" on the first line of %install to %{_bindir}. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review