Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707613 --- Comment #3 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-05-26 09:01:05 EDT --- (In reply to comment #2) > Hi Ankur! > > koji build works fine: > http://koji.fedoraproject.org/koji/taskinfo?taskID=3093194 > > So far I found the following problems: > > - Is it possible to add a group? (Maybe some of the groups you recently created > for this purpose?) I haven't added groups to comps yet. I didn't want to create empty ones :$. Anyway, the GROUPS tag here isn't the one that we add in comps (yum groups). It's one of those present in /usr/share/doc/rpm-4.9.0/GROUPS. Not sure if any of them fit in for this package though :/ > - if it is taken from a svn checkout, shouldn't it be named accordingly? > (http://fedoraproject.org/wiki/Packaging:NamingGuidelines). Something like > dcm4chee-test-2.6-YYYYMMDDsvn<rev>? > It is a svn checkout, but only because there isn't a release for this. It's tagged as version 2.6, so I'm not sure if I need to use the svn or the version. > And a thing I don't understand: > > - In the add_to_maven section, what are the project_group_id and > project_artifact_id? > I've corrected this part in the spec. > Please comment on those issues and I'll make a formal review. > > Thanks > > Mario http://ankursinha.fedorapeople.org/dcm4che2-test/dcm4che2-test-2.6-1.fc15.src.rpm http://ankursinha.fedorapeople.org/dcm4che2-test/dcm4che2-test.spec * Thu May 26 2011 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 2.6-1 - Correct add to maven depmap command - initial rpm build Thanks! Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review