[Bug 225672] Merge Review: cvs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225672

--- Comment #13 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-05-26 05:34:53 EDT ---
It used to work, but something has changes in rpm-4.8 because it does not work
in F14 now too. Removing the regular expression anchors make it effective
again:

diff --git a/cvs.spec b/cvs.spec
index ff2a8e5..b3f53a0 100644
--- a/cvs.spec
+++ b/cvs.spec
@@ -59,7 +59,7 @@ Patch25:
cvs-1.11.23-Set-PAM_TTY-and-PAM_RHOST-on-PAM-authentication.patch
 Patch26: cvs-1.11.23-Back-port-KeywordExpand-configuration-keyword.patch

 # Don't let find provides to add csh to automatic requires
-%filter_requires_in ^%{_datadir}/%{name}/contrib/sccs2rcs$
+%filter_requires_in %{_datadir}/%{name}/contrib/sccs2rcs
 %filter_setup

 %description

This contradicts to Fedora Packaging Guidelines now
(https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_provides_.28pre-scan_filtering.29).

I found by experiments, the expression has started to be compared against paths
with %{buildroot}. Therefore the ^expresion has stopped to match and thus this
one works too:

diff --git a/cvs.spec b/cvs.spec
index ff2a8e5..5bbdad0 100644
--- a/cvs.spec
+++ b/cvs.spec
@@ -59,7 +59,7 @@ Patch25:
cvs-1.11.23-Set-PAM_TTY-and-PAM_RHOST-on-PAM-authentication.patch
 Patch26: cvs-1.11.23-Back-port-KeywordExpand-configuration-keyword.patch

 # Don't let find provides to add csh to automatic requires
-%filter_requires_in ^%{_datadir}/%{name}/contrib/sccs2rcs$
+%filter_requires_in ^%{buildroot}%{_datadir}/%{name}/contrib/sccs2rcs$
 %filter_setup

 %description

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]