Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693233 --- Comment #4 from Adam Williamson <awilliam@xxxxxxxxxx> 2011-05-25 13:57:24 EDT --- The revised package builds on F15, good. Some problems in rpmlint: [adamw@adam SRPMS]$ rpmlint /var/lib/mock/fedora-15-x86_64/result/*.rpm nux.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libnux-0.9.so.0.944.4 ['/usr/lib64'] nux.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libnux-image-0.9.so.0.944.4 ['/usr/lib64'] nux.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libnux-graphics-0.9.so.0.944.4 ['/usr/lib64'] nux-devel-docs.x86_64: E: devel-dependency nux-devel nux-devel-docs.x86_64: W: devel-file-in-non-devel-package /usr/share/nux/gputests/framebufferobject.cpp nux-devel-docs.x86_64: W: devel-file-in-non-devel-package /usr/share/nux/gputests/texture_data.cpp nux-devel-docs.x86_64: W: devel-file-in-non-devel-package /usr/share/nux/gputests/texture_copy_blur.cpp nux-devel-docs.x86_64: W: devel-file-in-non-devel-package /usr/share/nux/gputests/texture_blur.cpp nux-devel-docs.x86_64: W: devel-file-in-non-devel-package /usr/share/nux/gputests/arb_programs_limits.cpp nux-devel-docs.x86_64: W: devel-file-in-non-devel-package /usr/share/nux/gputests/texture_power_of_2.cpp 5 packages and 0 specfiles checked; 4 errors, 6 warnings. please fix at least the rpath stuff, the others may be ignored if the source really is part of the docs. The license on the tests and examples is GPLv3, not LGPL; so set a License field on the devel-docs package. Aside from the above, this looks good. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review