Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690728 Jens Petersen <petersen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |608574 --- Comment #27 from Jens Petersen <petersen@xxxxxxxxxx> 2011-05-25 00:55:57 EDT --- (In reply to comment #25) > rpmlint output: > > nitrate.src: W: invalid-url URL: > https://fedorahosted.org/nitrate/browser/trunk/nitrate <urlopen error The read > operation timed out> Project URL should be https://fedorahosted.org/nitrate/ > nitrate.src:95: W: macro-in-comment %{_datadir} > nitrate.src:95: W: macro-in-comment %{name} Please remove the comment if it is not needed. > nitrate.noarch: E: explicit-lib-dependency python-hashlib This might be a rpmlint false positive? > nitrate.noarch: E: version-control-internal-file > /usr/share/nitrate/media/js/lib/tinymce/jscripts/tiny_mce/themes/advanced/skins/grappelli/img/buttons/.svn/text-base/search.png.svn-base Do you really need to include all all those .svn files? If not better to remove them at least from the binary package. Anyway looks like tinymce should be a separate package!! See the package review in bug 608574. It would be good if you could please do a check of the tinymce package and post any comments there in the review. > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/media/js/lib/highcharts/highcharts201.src.js > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/templates/run/all.html > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/templates/plan/all.html > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/odf/thumbnail.py 0644L > /usr/bin/python > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/odf/odfmanifest.py 0644L > /usr/bin/python > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/media/js/lib/highcharts/highcharts201.js > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/media/js/lib/highcharts/modules/exporting.js > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/odf/userfield.py 0644L > /usr/bin/python > nitrate.noarch: E: non-executable-script > /usr/share/nitrate/contrib/tools/sync_build.py 0644L /usr/bin/python > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/media/js/lib/highcharts/highcharts.js > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/setup.py 0644L > /usr/bin/env > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/templates/run/execute.html > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/odf/load.py 0644L > /usr/bin/python > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/djangotinymce/setup.py 0644L > /usr/bin/env > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/media/js/lib/highcharts/modules/exporting.src.js > nitrate.noarch: E: wrong-script-end-of-line-encoding > /usr/share/nitrate/media/js/lib/highcharts/modules/exporting.src.js > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/odf/element.py 0644L > /usr/bin/python > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/templates/case/all.html > nitrate.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/tcms/core/lib/odfpy/odf/elementtypes.py 0644L > /usr/bin/python > nitrate.noarch: E: script-without-shebang > /usr/share/nitrate/templates/profile/recent.html Most of these need some attention too I believe. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review