Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700346 --- Comment #8 from Iain Arnell <iarnell@xxxxxxxxx> 2011-05-23 23:48:34 EDT --- Okay. That's much better now. There's still a few minor points that I should have mentioned earlier: Although not explicitly mentioned in the packaging guidelines, it is implied that you should include your email address in the changelog entries (and it's certainly the convention to do so). See the examples: https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs And if you don't intend maintaining this in EPEL (all of these are still required for EPEL 4 and 5, though), there are a few simplifications that can be made (all of which would apply to your other packages too): You don't need to specify the BuildRoot tag any more. You don't need to 'rm -rf $RPM_BUILD_ROOT' at the start of %install section. You don't need %clean section at all. And in %files section, you can remove '%defattr(-,root,root,-)' line. These minor changes aren't considered blockers, so in principle, I'm happy to approve this as is. Since you have some more packages ready, I'll go ahead and review them too before continuing with sponsorship, but so far it's looking pretty good. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3088362 Spec looks sane, clean and consistent; license is correct (Public Domain); make test passes cleanly. Source tarballs match upstream (sha1sum): aa08a87236998d8bc475e669a635c1e654b02073 Barcode-Code128-2.01.tar.gz aa08a87236998d8bc475e669a635c1e654b02073 Barcode-Code128-2.01.tar.gz.srpm Final provides / requires are sane: ======> perl-Barcode-Code128-2.01-2.fc16.noarch.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides perl(Barcode::Code128) = 2.01 perl-Barcode-Code128 = 2.01-2.fc16 ====> requires perl >= 0:5.004 perl(Carp) perl(constant) perl(Exporter) perl(GD) perl(:MODULE_COMPAT_5.12.3) perl(strict) perl(vars) ====> obsoletes ====> conflicts ======> perl-Barcode-Code128-2.01-2.fc16.src.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(GD) ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.9 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.9 INFO: Mock Version: 1.1.9 State Changed: lock buildroot INFO: installing package(s): perl-Barcode-Code128-2.01-2.fc16.noarch.rpm INFO: ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Barcode-Code128 noarch 2.01-2.fc16 /perl-Barcode-Code128-2.01-2.fc16.noarch 42 k Installing for dependencies: fontconfig x86_64 2.8.0-3.fc15 fedora 183 k freetype x86_64 2.4.4-4.fc16 fedora 356 k gd x86_64 2.0.35-12.fc15 fedora 140 k libX11 x86_64 1.4.3-1.fc16 fedora 581 k libX11-common noarch 1.4.3-1.fc16 fedora 174 k libXau x86_64 1.0.6-2.fc15 fedora 24 k libXpm x86_64 3.5.8-3.fc15 fedora 58 k libjpeg-turbo x86_64 1.1.0-2.fc16 fedora 117 k libpng x86_64 2:1.2.44-3.fc15 fedora 180 k libxcb x86_64 1.7-2.fc15 fedora 100 k perl-GD x86_64 2.44-6.fc15 fedora 181 k Transaction Summary ================================================================================ Install 12 Package(s) Total size: 2.1 M Total download size: 181 k Installed size: 6.6 M Installed: perl-Barcode-Code128.noarch 0:2.01-2.fc16 Dependency Installed: fontconfig.x86_64 0:2.8.0-3.fc15 freetype.x86_64 0:2.4.4-4.fc16 gd.x86_64 0:2.0.35-12.fc15 libX11.x86_64 0:1.4.3-1.fc16 libX11-common.noarch 0:1.4.3-1.fc16 libXau.x86_64 0:1.0.6-2.fc15 libXpm.x86_64 0:3.5.8-3.fc15 libjpeg-turbo.x86_64 0:1.1.0-2.fc16 libpng.x86_64 2:1.2.44-3.fc15 libxcb.x86_64 0:1.7-2.fc15 perl-GD.x86_64 0:2.44-6.fc15 State Changed: unlock buildroot -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review