Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 ------- Additional Comments From bugs.michael@xxxxxxx 2006-12-31 11:10 EST ------- * In build log: gerbv.c:1526: warning: call to __builtin___snprintf_chk will always overflow destination buffer * Gerber file format support fails to load test files. * Drill file format support crashes with buffer overflow. * Passing files at the command-line results in 100% buffer overflow crash: *** buffer overflow detected ***: gerbv terminated ======= Backtrace: ========= /lib/libc.so.6(__chk_fail+0x41)[0x87c161] /lib/libc.so.6[0x87bba3] /lib/libc.so.6(__snprintf_chk+0x37)[0x87ba87] gerbv[0x8055686] gerbv[0x805625a] /lib/libglib-2.0.so.0[0x12a5e1] * Directories %{_datadir}/gerbv and %{_datadir}/gerbv/scheme are not included: $ rpmls -p /home/qa/tmp/rpm/RPMS/gerbv-1.0.2-1.i386.rpm -rwxr-xr-x /usr/bin/gerbv -rw-r--r-- /usr/share/applications/fedora-gerbv.desktop -rw-r--r-- /usr/share/gerbv/scheme/init.scm -rw-r--r-- /usr/share/icons/hicolor/48x48/apps/gerbv.png -rw-r--r-- /usr/share/man/man1/gerbv.1.gz * Scriptlets for GTK icon cache are missing: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda * No %doc files are included. Not even the GPL license. * Manual pages are marked %doc automatically. * Upstream project site contains the following warning: "If anyone is interested to takeover this project, please contact Stefan. Else this project will risk to rot away yet again." Hints: * It is commonly considered better style to make "Summary" in headline-style: Summary: Gerber file viewer from the gEDA toolkit * Second sentence in %description is missing punctuation. * Manual pages contains unexpanded ${prefix}. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review