Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706565 --- Comment #10 from David Nalley <david@xxxxxxx> 2011-05-22 14:06:45 EDT --- (In reply to comment #6) Inline reply: > Summary of SHOULD issues: > It is the weekend (May 22) and my test environment is currently under use > likely until Wed-Thur. This prevents 3 shoulds from being verified: > > SHOULD (DELAYED): The reviewer should test that the package builds in mock. > [27] > > I will test this on a workday. Koji will do builds in mock or you, so hopefully to save you a bit of time: Here are two scratch builds for x86 and x86_64 http://koji.fedoraproject.org/koji/taskinfo?taskID=3086136 http://koji.fedoraproject.org/koji/taskinfo?taskID=3086139 > > SHOULD (DELAYED): The package should compile and build into binary rpms on all > supported architectures. [28] > > I will test this on a workday. > > SHOULD (delayed until May 25): The reviewer should test that the package > functions as described. A package should not segfault instead of running, for > example. > > Also another item of work is as follows: > SHOULD (PASS): your package should contain man pages for binaries/scripts. If > it doesn't, work with upstream to add them where they make sense.[32] > > There is no man page for the cli tool collie. sdake will create man page and > submit upstream to sheepdog project, but this is not a blocker. > > This last work item doesn't block the package review, but I will take on > responsibility for adding this man page upstream. Expect to see it in an > updated tarball of sheepdog. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review