Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #9 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-05-22 13:01:23 EDT --- (In reply to comment #6) > [FAILED] MUST: The package must be licensed with a Fedora approved license and > meet the Licensing Guidelines. > -> Should be "GPLv2+ and MIT" because of aswvdial/strlcpy.c file Just a small correction: The License field should reflect the license of the files in the binary package, not the single licenses of all involved source files. As MIT is compatible with GPLv2+, and as the code of strlcpy.c is linked into aswvdial, we get a binary licensed under GPLv2+ (GPLv2+ + MIT = GPLv2+). If strlcpy.c were linked and packaged as a separate binary, this binary would be MIT-licensed and "GPLv2+ and MIT" would be correct. Also, the %optflags are not applied. Simply add OPT="%{optflags}" to the make statement to fix this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review