Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706565 Steven Dake <sdake@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Steven Dake <sdake@xxxxxxxxxx> 2011-05-22 12:12:43 EDT --- MUSTS first: MUST (1 warning): rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] [sdake@beast Downloads]$ rpmlint -v sheepdog-0.2.3-1.fc14.src.rpm sheepdog.src: I: checking sheepdog.src: W: name-repeated-in-summary C Sheepdog sheepdog.src: I: checking-url http://www.osrg.net/sheepdog (timeout 10 seconds) sheepdog.src: I: checking-url http://downloads.sourceforge.net/project/sheepdog/sheepdog/0.2.3/sheepdog-0.2.3.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. + cd sheepdog-0.2.3 + rm -rf /home/sdake/rpmbuild/BUILDROOT/sheepdog-0.2.3-1.fc14.x86_64 + exit 0 [sdake@beast SPECS]$ rpmlint -v /home/sdake/rpmbiuld/BUILDROOT/sheepdog-0.2.3-1.fc14.x86_64 (none): E: no installed packages by name /home/sdake/rpmbiuld/BUILDROOT/sheepdog-0.2.3-1.fc14.x86_64 0 packages and 0 specfiles checked; 0 errors, 0 warnings. MUST (PASSES): The package must be named according to the Package Naming Guidelines . package passes naming guidelines. MUST (PASSES): The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . {name}.spec == package %{name} MUST: The package must meet the Packaging Guidelines . MUST (PASSES): The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . GPL are approved licenses MUST(FAIL): The License field in the package spec file must match the actual license. [3] The package license is GPLv2, not GPLv2+. Looking through the source files, I don't see any references to GPLv3 - if you can point me at them, I'll make sure they get fixed upstream. MUST (PASS) : If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] COPYING in %doc section MUST (PASS): The spec file must be written in American English. [5] spec file is in English. MUST (PASS): The spec file for the package MUST be legible. [6] spec file is legible. MUST (PASS): The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. from upstream: from upstream: [sdake@beast Downloads]$ md5sum sheepdog-0.2.3.tar.gz 2348fd7121558e4efe9cab1fda4bf70a sheepdog-0.2.3.tar.gz from rpm: [sdake@beast SOURCES]$ md5sum sheepdog-0.2.3.tar.gz 2348fd7121558e4efe9cab1fda4bf70a sheepdog-0.2.3.tar.gz MUST (PASS): The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] verified builds on X86_64 architecture MUST (NEEDHELP): If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8] I am not sure how to verify this. Last I recall, we turned off builds of dependent packages on some architectures in fedora, which would make building this difficult. I will get back to you on this point Monday. MUST (PASS): All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. Verified that the build deps of autotools and corosynclib-devel are sufficient to build from a minimal install + the default packages always located in the buildroot. MUST (PASS): The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] no locales used. MUST (PASS): Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] no shared libraries in package. MUST (PASS): Packages must NOT bundle copies of system libraries.[11] there are no bundled system libraries. MUST (PASS): If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12] Prefix: /usr is not used. Review request not asked for relocateable feature. MUST (PASS): A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] There is only one directory that sheepdog init scripts use, and it is declared in the spec files section. MUST (PASS): A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] No files are listed multiple times. MUST (PASS): Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15] permissions are appropiately set. MUST (PASS): Each package must consistently use macros. [16] macro usage is consistent. MUST (PASS): The package must contain code, or permissable content. [17] The package contains only code, build scripts, license text, and documentation. MUST (PASS): Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] The package contains only minimal readme documentation and man pages which are not significant in size and can reside in the main package. MUST (PASS): If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18] The %doc files do not impact the runtime of the software. MUST (PASS): Header files must be in a -devel package. [19] no header files are packaged. MUST (PASS): Static libraries must be in a -static package. [20] no static libraries are packaged. MUST (PASS): If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] The package contains no shared objects. MUST (PASS): In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [21] There is no devel package. MUST (PASS): Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20] libtool is not used by this project. MUST (PASS): Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22] This package has no GUI. MUST (PASS): Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] This package only owns one directory which is sheepdog specific. MUST (PASS): All filenames in rpm packages must be valid UTF-8. [24] All files are UTF-8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review