Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703322 --- Comment #17 from Golo Fuchert <packages@xxxxxxxxxx> 2011-05-21 07:59:51 EDT --- Yes, there are still some issues with this package. - Right now, the Requirements (i.e. emacs-filesystem) guarantee the ownership of %{_emacs_sitelispdir} only for F15, since the package is not available for F<15. There are packages, which do own %{_emacs_sitelispdir} there, however, none of that is required by tpp. So tpp has to own it as well, otherwise after the uninstall of tpp that dir might remain and pollute the user's system. So, in the %files section we need %if 0%{?fedora} < 15 %dir %{_emacs_sitelispdir}/ %endif - You can think of the install command as a cp, so in the build section you copy all files from contrib to the emacs and vim related directories. Then, however, you add the contrib folder to the %doc files. Not only is this useless, but a file is not allowed to be packaged more than once without good reason. - In the newest %changelog entry the mail address is now missing completely. http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs - rpmlint still complains about the wrong fsf address, this won't block tpp I guess, however, upstream should really be informed in order to fix this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review