Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Kalev Lember <kalev@xxxxxxxxxxxx> 2011-05-20 10:22:32 EDT --- Fedora review grilo-plugins-0.1.15-3.src.rpm 2011-05-20 + OK ! needs attention koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3083534 $ rpmlint grilo-plugins \ grilo-plugins-0.1.15-3.src.rpm \ grilo-plugins-debuginfo-0.1.15-3.x86_64.rpm grilo-plugins.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged grilo-plugins.src: W: spelling-error %description -l en_US fm -> FM, Fm, gm grilo-plugins.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal grilo-plugins.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged grilo-plugins.x86_64: W: spelling-error %description -l en_US fm -> FM, Fm, gm grilo-plugins.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal 3 packages and 0 specfiles checked; 0 errors, 6 warnings. + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the package base name + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 29efa89f3842787c21271a7513a9a1ab grilo-plugins-0.1.15.tar.bz2 29efa89f3842787c21271a7513a9a1ab Download/grilo-plugins-0.1.15.tar.bz2 + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable ! Package currently doesn't own all directories it creates, but it's going to be fixed in grilo package as per comment #4 + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package It's a plugin package, not applicable. n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8 Remaining issues: - add the missing directories to grilo package; - take a look at comment #6 if you want to remove BuildRoot and %clean - I'd suggest to add the %{?dist} macro to Release These can all be fixed before importing the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review