Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #4 from Bastien Nocera <bnocera@xxxxxxxxxx> 2011-05-20 09:41:27 EDT --- (In reply to comment #3) > Taking for review. > > 1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of %install > section, the whole %clean section, and the %defattr lines are no longer needed > in current Fedora releases and you could remove them, if you want to. Done. > 2) You are removing %{_libdir}/grilo-0.1/*.a in %install section after building > them, but it might be cleaner to avoid building the static libs in the first > place. Does configure --disable-static work for this package? That works indeed. > 3) Some of the directories aren't owned by any package and that would cause > empty directories to be left behind when uninstalling the package. > Either (a) grilo, or (b) all grilo's plugin packages should own these dirs: > %{_libdir}/grilo-0.1/ > %{_datadir}/grilo-0.1/ > %{_datadir}/grilo-0.1/plugins/ I'll add those directories in grilo itself. > 4) The source URL currently looks like this: > http://ftp.gnome.org/pub/GNOME/sources/grilo-plugins/0.1/grilo-plugins-%{version}.tar.bz2 > > It might be nice to automatically figure out the '0.1' directory name, so that > it would only be necessary to update the Version: field when building updates. > I have used shell scripting in a some packages to accomplish that; not sure if > it's something you'd want to use here. Pretty much every single GNOME tarball has that exact same problem. > At the top of the spec file I've put this: > # first two digits of version > %define release_version %(echo %{version} | awk -F. '{print $1"."$2}') > > ... and in the Source0 tag, instead of the hardcoded '0.1' goes > %{release_version} macro. But I've done that now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review