Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 Volker FrÃhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker FrÃhlich <volker27@xxxxxx> 2011-05-19 17:11:28 EDT --- You can use the name macro in the tarball name. The license is AGPLv3+. Rpmlint still complains, because the license was forgotten in the list of acceptable licenses. It is included by now. Requiring a Python newer or equal to 2.6 is not necessary, as all Fedora versions have it. If you consider maintaining it in EPEL 5 as well, you must add a clean section and rm -rf the buildroot in the install section. In that case please also pick a BuildRoot syntax from http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag If you don't want to maintain in EPEL, drop the buildroot definition. Besides that, FOR_PACKAGERS points out Python 2.4 would also work. Rather use %global than %define. defattr seems unnecessary now: https://fedorahosted.org/fpc/ticket/77 But if you use it, add the minus in the end: %defattr(-,root,root,-) Drop the -n %{name}-%{version} from the setup macro. It's not necessary. You also don't have to define the __python macro. It's good practice to backup patched files like: %patch1 -p1 -b .something_that_identifies_the_patch Don't use the install macro. Just use the normal command. Probably put a few comments to make everything clear. Especially when you decide to do other than obvious. Why do you need to have executable __init__.py (chmod)? The unitdir macro is not defined. Thus a rebuild fails. The paths inside FROM_NAGIOS_TO_SHINKEN don't reflect the situation for Fedora. Other files may be affected as well. Please check the paths in the config files, whether the targets exist and are sane. I can see /usr/local/... README is only a symlink pointing towards README.rst -- no need to include it. Any chance to run the unit tests? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review