Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #5 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2011-05-19 14:04:20 EDT --- licensing: OK scriptlets: OK naming: OK URL provided doesn't work for me, please find something better. Not a blocker. rpmlint: clean, OK builds/installs OK In a perfect world, I'd like to see comment #3 addressed too, wrt keeping library naming more consistent, using something from trever's .spec he showed us earlier today: %build echo 'yes' | \ ./configure -library echo "QTSOAP_LIBNAME = \$\$qtLibraryTarget(qtsoap)" >> common.pri echo "VERSION=%{version}" >> common.pri qmake-qt4 make %{?_smp_mflags} But, I'll leave it up to you on how best to resolve that (with some potential upstream poking). not a blocker. Otherwise, looks good, APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review