Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705376 --- Comment #3 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2011-05-19 04:15:31 EDT --- (In reply to comment #2) > [!] Package meets the Packaging Guidelines including the Perl specific items > > Requires: perl(HTML::LinkExtor) > Requires: perl(LWP::UserAgent) > Requires: perl(MIME::Lite) >= 1 > Requires: perl(Test::More) > Requires: perl(URI::URL) > > perl(Test::More) is a BuildRequires, not a Requires as far as I can see. > All of the others are detected by auto-Requires. There is no need to include > them by hand. There is no need to version the requirement perl(MIME::Lite). > Please fix these. > Fixed. cpanspec was overzealous and I was too lazy when checking the spec :-(. > Please consider removing the obsolete BuildRoot cleaning in %install section. > Please consider removing the already implicit %defattr in %files section. > Needed for EL 5 and I'd rather keep the spec branches sync'ed. > [x] Rpmlint output: > perl-MIME-Lite-HTML.noarch: E: incorrect-fsf-address > /usr/share/doc/perl-MIME-Lite-HTML-1.23/COPYING > 2 packages and 1 specfiles checked; 1 errors, 0 warnings. > > This again? Xavier, please consider filing a bug upstream to correct this. > Done : https://rt.cpan.org/Public/Bug/Display.html?id=68303 > [x] Buildroot is correct > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > While this is correct, it's only used in EPEL5. > In any other branch, this will be ignored. > See above, I'm targeting EL5 too. > [x] If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package is included in %doc. > > Again, please file a bug with upstream asking them to update their COPYING > file. > See above. Spec URL: http://www.bachelot.org/fedora/SPECS/perl-MIME-Lite-HTML.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-MIME-Lite-HTML-1.23-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review