Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700667 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |paul@xxxxxxxxxxxx Flag| |fedora-review+ --- Comment #13 from Paul Howarth <paul@xxxxxxxxxxxx> 2011-05-17 11:19:43 EDT --- rpmlint output ============== python26-crypto.x86_64: W: file-not-utf8 /usr/share/doc/python26-crypto-2.3/LEGAL/copy/stmts/Paul_Swartz.mbox python26-crypto.x86_64: E: backup-file-in-package /usr/share/doc/python26-crypto-2.3/LEGAL/copy/LICENSE.orig The first of these is a set of emails, with explicit encoding. The second is a false positive - the file originates upstream and not from a patch. review checklist ================ - rpmlint OK (see above) - package and spec naming follows convention for python26 packages in EPEL - package meets guidelines - license is OK for Fedora and matches upstream (see upstream COPYRIGHT file) - upstream licensing texts included in %doc - spec file written in English and is legible - source matches upstream - package builds find in mock for EPEL-5 - buildreqs ok - no locale data to worry about - package does not include shared libraries in dynamic linker's default paths - package does not bundle copies of system libraries - package is not intended to be relocatable - no directory ownership issues - no duplicate files - file permissions are fine - macro usage is consistent - code, not content - no large docs included - docs don't affect runtime - no devel files included - not a GUI app so no desktop file needed - filenames are all valid UTF-8 - upstream test suite and benchmark script run in %check - no scriptlets needed or included - no subpackages warranted or created - no file dependencies - no binaries/scripts included, so no manpages warranted All in all, no problems found. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review