Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701845 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Daiki Ueno <dueno@xxxxxxxxxx> 2011-05-17 02:06:17 EDT --- It still warns about duplicate files: warning: File listed twice: /usr/share/doc/shunit2-2.1.6/examples We could simply change: %dir %{_docdir}/%{name}-%{version} %dir %{_docdir}/%{name}-%{version}/examples %doc %{_docdir}/%{name}-%{version}/* to: %{_docdir}/%{name}-%{version} ? Even then, files under %{_docdir} seems to be automatically marked as %doc. Except for this, the packaging looks fine. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review