Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701028 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2011-05-14 04:25:31 EDT --- Some notes (not a review) - version is not correct for a pre-release version (1.0-0.1.b1) http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages - use a simple sed instead of dos2unix (avoid dependency) - don't install doc, list them in %file is enough %doc README COPYING Changelog - what is the goal of the 01_fix_binary_license.patch ? only to change "space" (diff -b is empty) ? I don't think it is really usefull... - name is not correct http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 and http://fedoraproject.org/wiki/Packaging/PHP#Naming_scheme - removing .php suffix from installed binary seems a good idea - shebang must be fixed ("/usr/bin/env php" => %{_bindir}/php) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review