Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689815 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-05-13 07:34:12 EDT --- Source tar ball is original. Ok. Summary verified from lib/MooseX/Role/TraitConstructor.pm. Ok. License verified from lib/MooseX/Role/TraitConstructor.pm. Ok. Description verified from lib/MooseX/Role/TraitConstructor.pm. Ok. No XS found, noarch BuildArch is Ok. FIX: Remove useless Requires: perl(Test::Exception) Fix: Remove useless Requires: perl(Test::use::ok) TODO: Remove useless %defattr and %doc macros from %files section All tests pass. Ok. $ rpmlint perl-MooseX-Role-TraitConstructor.spec ../SRPMS/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.src.rpm ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm -rw-r--r-- 1 root root 3121 kvÄ 13 11:46 /usr/share/man/man3/MooseX::Role::TraitConstructor.3pm.gz drwxr-xr-x 2 root root 0 kvÄ 13 11:46 /usr/share/perl5/MooseX drwxr-xr-x 2 root root 0 kvÄ 13 11:46 /usr/share/perl5/MooseX/Role -rw-r--r-- 1 root root 5779 dub 27 2008 /usr/share/perl5/MooseX/Role/TraitConstructor.pm File permissions and layout Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm |sort |uniq -c 1 perl(constant) 2 perl(List::Util) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(Moose::Role) 1 perl(Moose) >= 0.40 1 perl(Test::Exception) 1 perl(Test::use::ok) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 TODO: Remove explicit Requires for auto-discovered perl(List::Util) $ rpm -q --provides -p ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm |sort |uniq -c 1 perl(MooseX::Role::TraitConstructor) = 0.01 1 perl-MooseX-Role-TraitConstructor = 0.01-1.fc14 Binary provides Ok. $ resolvedeps dist-f16 ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3069316). Ok. Otherwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' issues and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review