Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695819 Jaroslav Åkarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag| |fedora-review+ --- Comment #5 from Jaroslav Åkarvada <jskarvad@xxxxxxxxxx> 2011-05-12 11:32:15 EDT --- Looks good. MUST items: [YES] rpmplint is silent (not counting false positives about spelling) [YES] Package meets naming guidelines. [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [YES] License file is present, matching with spec file. [YES] Licensing Guidelines are met. [YES] Spec file is legible and in American English. [YES] Sources match upstream. [YES] Package builds OK. [YES] BuildRequires is correct. [YES] Package doesn't bundle copies of system libraries. [YES] Package has no duplicity in %files. [YES] Permission on files are set properly. [YES] %doc doesn't affect runtime. [YES] Spec file has consistant macro usage. [YES] Package is code or permissable content. [YES] No .la libtool archives. [YES] Package doesn't own files/directories that other packages own. [YES] Spec file is valid UTF-8. SHOULD items: [YES] Package builds in mock. [YES] Package should build on all supported architectures. [YES] Package passed simple functional test. [YES] Used scriptlets are sane. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review