Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701450 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-05-08 13:55:43 EDT --- Some things are still to be fixed: - The package seems to provide a pre-release as the tarball is tagged as beta. Thus, the Release field should look like this: 0.1.git%{git}%{?dist} http://fedoraproject.org/wiki/PackageNamingGuidelines#Pre-Release_packages - Prefix the patch name with %{name}- or %{name}-%{version}- and, as Mario already mentioned, add a comment about what the patch does. - The package currently doesn't own %{_datadir}/%{name}/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review