Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684475 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Iain Arnell <iarnell@xxxxxxxxx> 2011-05-08 02:06:01 EDT --- + source files match upstream. 5821d20d4e4b86f8ff996320ece2424b wmblob-1.0.3.tar.bz2 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. - license field matches the actual license. GPLv2+ (according to README) + license is open source-compatible. + license text included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock https://koji.fedoraproject.org/koji/taskinfo?taskID=3057825 + package installs properly. + rpmlint has no meaningful complaints: wmblob.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage wmblob.src: I: enchant-dictionary-not-found de wmblob.x86_64: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage wmblob.x86_64: I: enchant-dictionary-not-found de wmblob.x86_64: E: incorrect-fsf-address /usr/share/doc/wmblob-1.0.3/COPYING wmblob-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmblob-1.0.3/src/getopt.h + final provides and requires are sane + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. You should inform upstream about the incorrect fsf address in COPYING, but no further action necessary. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review