Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682704 Steve Milner <smilner@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smilner@xxxxxxxxxx --- Comment #2 from Steve Milner <smilner@xxxxxxxxxx> 2011-05-06 21:20:04 EDT --- Thank you for submitting this package for review! I've been waiting for someone to be interested in taking it on. Some prereview data: * New version has been released since originally posted * SRPM builds fine on x86_64. * rpmlint output. Only possible issue is the line ending whicah can be fixed with %{__sed} -i 's/\r//' uwsgi-wiki-doc*.txt: $ rpmlint /home/steve/rpmbuild/RPMS/x86_64/uwsgi-0.9.6.8-1.fc14.x86_64.rpm uwsgi.x86_64: W: spelling-error %description -l en_US interprocess -> inter process, inter-process, interpreters uwsgi.x86_64: W: spelling-error %description -l en_US preforking -> preforming, preform, preferring uwsgi.x86_64: W: spelling-error %description -l en_US evented -> evened, vented, e vented uwsgi.x86_64: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, subroutine uwsgi.x86_64: W: spelling-error %description -l en_US uGreen -> u Green, Green, green uwsgi.x86_64: W: spelling-error %description -l en_US xml -> XML, cml, ml uwsgi.x86_64: W: spelling-error %description -l en_US ini -> uni, in, ii uwsgi.x86_64: W: spelling-error %description -l en_US yaml -> yam, amyl, yams uwsgi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/uwsgi-0.9.6.8/uwsgi-wiki-doc-v15.txt uwsgi.x86_64: W: no-manual-page-for-binary uwsgi 1 packages and 0 specfiles checked; 0 errors, 10 warnings. * Sources match: 4a9b8bef52e2ff60fab645d595d1128e ../SOURCES/uwsgi-0.9.6.8.tar.gz 4a9b8bef52e2ff60fab645d595d1128e uwsgi-0.9.6.8.tar.gz I think it would be very helpful to add a subpackage or a sibling package for the apache2 uwsgi module. For the heck of it I'm attaching a sibling package spec based on yours :-). Thanks for working on this package, and good luck with the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review